Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Get/Put/Delete tags on searches #9934

Merged

Conversation

AmanuelAaron
Copy link
Contributor

@AmanuelAaron AmanuelAaron commented Sep 16, 2024

Ticket

ET-695
ET-696
ET-699

Description

Create Get/Put/Delete tag endpoints for Run Centric API

Test Plan

added tests should pass

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Sep 16, 2024
@AmanuelAaron AmanuelAaron changed the title feat: Aaron amanuel/run centric api feat: Get/Put/Delete tags on searches Sep 16, 2024
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 49.69%. Comparing base (904fb1f) to head (5cbb89c).

Files with missing lines Patch % Lines
master/internal/api_search.go 89.65% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (904fb1f) and HEAD (5cbb89c). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (904fb1f) HEAD (5cbb89c)
harness 8 3
Additional details and impacted files
@@                        Coverage Diff                         @@
##           feature/ET-684/run-centric-api    #9934      +/-   ##
==================================================================
- Coverage                           59.14%   49.69%   -9.46%     
==================================================================
  Files                                 752     1092     +340     
  Lines                              104553   144395   +39842     
  Branches                             3601     3600       -1     
==================================================================
+ Hits                                61834    71750    +9916     
- Misses                              42586    72512   +29926     
  Partials                              133      133              
Flag Coverage Δ
harness 43.21% <ø> (-29.54%) ⬇️
web 54.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
master/internal/api_experiment.go 59.65% <100.00%> (ø)
master/internal/api_search.go 81.91% <89.65%> (ø)

... and 760 files with indirect coverage changes

@AmanuelAaron AmanuelAaron marked this pull request as ready for review September 16, 2024 14:51
@AmanuelAaron AmanuelAaron requested a review from a team as a code owner September 16, 2024 14:51
@AmanuelAaron AmanuelAaron changed the base branch from jta/spike-rename-search-props-ET-693 to feature/ET-684/run-centric-api September 16, 2024 18:27
@AmanuelAaron AmanuelAaron changed the base branch from feature/ET-684/run-centric-api to jta/spike-rename-search-props-ET-693 September 16, 2024 18:29
@jesse-amano-hpe jesse-amano-hpe force-pushed the jta/spike-rename-search-props-ET-693 branch from 72d441a to 2265d5f Compare September 17, 2024 16:48
Base automatically changed from jta/spike-rename-search-props-ET-693 to feature/ET-684/run-centric-api September 19, 2024 17:14
@AmanuelAaron AmanuelAaron merged commit 2774476 into feature/ET-684/run-centric-api Sep 20, 2024
64 of 83 checks passed
@AmanuelAaron AmanuelAaron deleted the aaron_amanuel/run-centric-api branch September 20, 2024 17:21
jesse-amano-hpe added a commit that referenced this pull request Sep 20, 2024
jesse-amano-hpe added a commit that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants