Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kunapuli/manage job tcp #9948

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Kunapuli/manage job tcp #9948

wants to merge 2 commits into from

Conversation

kkunapuli
Copy link
Contributor

@kkunapuli kkunapuli commented Sep 17, 2024

Ticket

Description

Test Plan

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Sep 17, 2024
Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 691519e
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66e9e2caf7d7d80008684673
😎 Deploy Preview https://deploy-preview-9948--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.63%. Comparing base (26b0954) to head (691519e).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9948      +/-   ##
==========================================
- Coverage   54.51%   49.63%   -4.89%     
==========================================
  Files        1252     1091     -161     
  Lines      156668   144301   -12367     
  Branches     3601     3599       -2     
==========================================
- Hits        85411    71621   -13790     
- Misses      71124    72547    +1423     
  Partials      133      133              
Flag Coverage Δ
harness 43.21% <ø> (-29.54%) ⬇️
web 54.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
master/internal/command/command.go 66.80% <ø> (ø)
master/internal/command/command_job_service.go 0.00% <ø> (ø)
...ternal/configpolicy/postgres_task_config_policy.go 93.44% <ø> (ø)
master/internal/configpolicy/utils.go 95.83% <ø> (ø)
...ster/internal/rm/agentrm/agent_resource_manager.go 48.58% <ø> (ø)
...nal/rm/dispatcherrm/dispatcher_resource_manager.go 18.66% <ø> (ø)
...nal/rm/kubernetesrm/kubernetes_resource_manager.go 27.67% <ø> (ø)
master/internal/rm/multirm/multirm.go 63.67% <ø> (ø)
master/internal/rm/resource_manager_iface.go 70.00% <ø> (ø)

... and 261 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant