Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: check task config policy priority limit for [CM-490] #9958

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kkunapuli
Copy link
Contributor

@kkunapuli kkunapuli commented Sep 18, 2024

Ticket

CM-490

Description

Includes a check for a priority limit set via task config policies in the "manage job" workflow. Includes support for NTSC, and Experiments. It works for policies set for Workspaces, and Global scope.

Test Plan

Covered by unit and integration tests.

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Sep 18, 2024
Copy link

netlify bot commented Sep 18, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit dd45303
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66eb3d78cc33360008305092

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 46.26866% with 36 lines in your changes missing coverage. Please review.

Project coverage is 54.51%. Comparing base (d943d85) to head (dd45303).

Files with missing lines Patch % Lines
master/internal/experiment_job_service.go 0.00% 16 Missing ⚠️
master/internal/command/command_job_service.go 0.00% 11 Missing ⚠️
...ternal/configpolicy/postgres_task_config_policy.go 86.36% 3 Missing ⚠️
master/internal/configpolicy/task_config_policy.go 85.71% 2 Missing ⚠️
...ster/internal/rm/agentrm/agent_resource_manager.go 0.00% 1 Missing ⚠️
...nal/rm/dispatcherrm/dispatcher_resource_manager.go 0.00% 1 Missing ⚠️
...nal/rm/kubernetesrm/kubernetes_resource_manager.go 0.00% 1 Missing ⚠️
master/internal/rm/multirm/multirm.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9958      +/-   ##
==========================================
- Coverage   54.51%   54.51%   -0.01%     
==========================================
  Files        1252     1253       +1     
  Lines      156687   156753      +66     
  Branches     3600     3601       +1     
==========================================
+ Hits        85423    85457      +34     
- Misses      71131    71163      +32     
  Partials      133      133              
Flag Coverage Δ
backend 45.20% <46.26%> (+<0.01%) ⬆️
harness 72.74% <ø> (ø)
web 54.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
master/internal/rm/resource_manager_iface.go 70.00% <ø> (ø)
...ster/internal/rm/agentrm/agent_resource_manager.go 48.47% <0.00%> (-0.11%) ⬇️
...nal/rm/dispatcherrm/dispatcher_resource_manager.go 18.64% <0.00%> (-0.02%) ⬇️
...nal/rm/kubernetesrm/kubernetes_resource_manager.go 27.59% <0.00%> (-0.09%) ⬇️
master/internal/rm/multirm/multirm.go 63.41% <0.00%> (-0.26%) ⬇️
master/internal/configpolicy/task_config_policy.go 85.71% <85.71%> (ø)
...ternal/configpolicy/postgres_task_config_policy.go 90.78% <86.36%> (-1.81%) ⬇️
master/internal/command/command_job_service.go 0.00% <0.00%> (ø)
master/internal/experiment_job_service.go 5.45% <0.00%> (-2.05%) ⬇️

... and 7 files with indirect coverage changes

@kkunapuli kkunapuli marked this pull request as ready for review September 18, 2024 21:17
@kkunapuli kkunapuli requested review from a team as code owners September 18, 2024 21:17
@kkunapuli kkunapuli requested review from jesse-amano-hpe and amandavialva01 and removed request for jesse-amano-hpe September 18, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant