Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show - for empty data in searches table [ET-749] #9963

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

EmilyBonar
Copy link
Contributor

@EmilyBonar EmilyBonar commented Sep 19, 2024

Ticket

ET-749

Description

Test Plan

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 01d87f6
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66ec7aa7461c71000814e328
😎 Deploy Preview https://deploy-preview-9963--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 18.34862% with 89 lines in your changes missing coverage. Please review.

Project coverage is 50.44%. Comparing base (0db2e3b) to head (01d87f6).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
webui/react/src/components/Searches/columns.ts 15.38% 88 Missing ⚠️
webui/react/src/pages/FlatRuns/columns.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9963      +/-   ##
==========================================
- Coverage   54.46%   50.44%   -4.02%     
==========================================
  Files        1252      943     -309     
  Lines      156703   128119   -28584     
  Branches     3600     3600              
==========================================
- Hits        85341    64625   -20716     
+ Misses      71229    63361    -7868     
  Partials      133      133              
Flag Coverage Δ
harness ?
web 54.28% <18.34%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../react/src/components/ExperimentActionDropdown.tsx 79.79% <100.00%> (ø)
webui/react/src/pages/FlatRuns/columns.ts 18.98% <75.00%> (ø)
webui/react/src/components/Searches/columns.ts 50.80% <15.38%> (+0.39%) ⬆️

... and 309 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant