Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ethers-v5] Separate import and type import #737

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

noy4
Copy link

@noy4 noy4 commented Jul 4, 2022

This PR fixes:

  1. importing types without 'import type' was problematic with svelte vite
  2. importing not type object with 'import type' was problematic with svelte vite

I faced a same problem with this Issue: #732

image

This problem for contract typings was fixed by this PR: #636, but not for contract factory (maybe it was left out).

I simply turned everything in ethers to be imported with import type in Some__factory.ts, but faced another problem↓

image

So, I separated import and import type for ethers.

image

@changeset-bot
Copy link

changeset-bot bot commented Jul 4, 2022

⚠️ No Changeset found

Latest commit: 5e20fa5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tfalencar
Copy link

@krzkaczor do you see any issues with this PR?

@vojtechsimetka
Copy link

Any ETA when this can be merged? I'll gladly help if there is some code needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants