Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import type now includes the module suffix. #888

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

scnale
Copy link

@scnale scnale commented Dec 12, 2023

This is necessary for interpreters like ts-node or tsx that compile typescript just in time.

If you checkout this repository in this particular branch and run:

make dependencies
make build
npx tsc --noEmit --project tsconfig.json

You'll get errors for the import type directives because they're not pointing at modules nor have the .js suffix.
If you build and link the typechain package in this branch, and run the yarn build-types command the codegen will be correct.

This is necessary for interpreters like `ts-node` that compile
typescript just in time.
Copy link

changeset-bot bot commented Dec 12, 2023

⚠️ No Changeset found

Latest commit: c79da19

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant