-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add contract address calculator based on from and nonce #95
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@7sne hi. Any chance this and my other PR will be merged? I use the address calculator extensively at work and it would be nice if it was accessible at https://tools.deth.net. |
Hello @olehmisar. I'm really glad and thankful for your contributions to this project. Unfortunately, I've been really busy lately and have little time for this project. Anyways, I will try to look into your changes as soon as I can. |
@@ -0,0 +1,102 @@ | |||
import { getContractAddress } from '@ethersproject/address'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also write the tests for this tool? That's a must-have for tools.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@olehmisar Everything is okay, but the contract-address-calculator
page is still missing the tests. Check other pages, all of them have tests and that's a must-have. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tool page missing test
Closes #88