Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contract address calculator based on from and nonce #95

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

olehmisar
Copy link
Contributor

@olehmisar olehmisar commented Oct 3, 2022

Closes #88

@vercel
Copy link

vercel bot commented Oct 3, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2023 7:20pm

@olehmisar
Copy link
Contributor Author

olehmisar commented Mar 1, 2023

@7sne hi. Any chance this and my other PR will be merged? I use the address calculator extensively at work and it would be nice if it was accessible at https://tools.deth.net.

@7sne
Copy link
Collaborator

7sne commented Mar 2, 2023

@7sne hi. Any chance this and my other PR will be merged? I use the address calculator extensively at work and it would be nice if it was accessible at https://tools.deth.net.

Hello @olehmisar. I'm really glad and thankful for your contributions to this project. Unfortunately, I've been really busy lately and have little time for this project. Anyways, I will try to look into your changes as soon as I can.

pages/contract-address-calculator/index.page.tsx Outdated Show resolved Hide resolved
pages/vanity-address-generator/index.page.tsx Show resolved Hide resolved
src/misc/validation/validators/numberValidator.ts Outdated Show resolved Hide resolved
@@ -0,0 +1,102 @@
import { getContractAddress } from '@ethersproject/address';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also write the tests for this tool? That's a must-have for tools.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olehmisar Everything is okay, but the contract-address-calculator page is still missing the tests. Check other pages, all of them have tests and that's a must-have. Thanks!

Copy link
Collaborator

@7sne 7sne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tool page missing test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New tool] Find an address of a contract deployed from tx X at nonce Y
2 participants