Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cuda support for 12.3 .. 12.5 #1119

Merged
merged 4 commits into from
Sep 23, 2024
Merged

cuda support for 12.3 .. 12.5 #1119

merged 4 commits into from
Sep 23, 2024

Conversation

prathameshzarkar9
Copy link
Contributor

No description provided.

@prathameshzarkar9 prathameshzarkar9 requested a review from a team as a code owner September 12, 2024 14:03
@prathameshzarkar9 prathameshzarkar9 marked this pull request as draft September 12, 2024 14:04
@prathameshzarkar9 prathameshzarkar9 marked this pull request as ready for review September 16, 2024 17:59
samruddhikhandale
samruddhikhandale requested changes Sep 16, 2024
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left minor comments, besides that looks wonderful.

src/nvidia-cuda/install.sh Outdated Show resolved Hide resolved
src/nvidia-cuda/install.sh Outdated Show resolved Hide resolved
@samruddhikhandale samruddhikhandale linked an issue Sep 16, 2024 that may be closed by this pull request
Features: CUDA 12.3-12.5 and corresponding cudnn #1070
Closed
samruddhikhandale
samruddhikhandale approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thanks!

@samruddhikhandale samruddhikhandale merged commit 1a6b715 into devcontainers:main Sep 23, 2024
12 checks passed
@samruddhikhandale samruddhikhandale mentioned this pull request Sep 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samruddhikhandale samruddhikhandale samruddhikhandale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Features: CUDA 12.3-12.5 and corresponding cudnn
2 participants
@prathameshzarkar9 @samruddhikhandale