Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Deck.gl to version 9 #562

Merged
merged 8 commits into from
Aug 13, 2024
Merged

Upgrade Deck.gl to version 9 #562

merged 8 commits into from
Aug 13, 2024

Conversation

vgeorge
Copy link
Member

@vgeorge vgeorge commented Jul 3, 2024

Contributes to #422.

This is a work in progress. The north-america-roads example works and type checks pass, but I haven't been able to test this thoroughly yet.

cc @kylebarron @batpad

@kylebarron
Copy link
Member

Awesome! I'll take a look through some examples!

@kylebarron
Copy link
Member

Hmm it looks like the HeatmapLayer is broken. Which you can see from the duckdb example notebook.
image

I would initially assume this is an upstream deck.gl bug. Ah yes, looks like we're hitting this: visgl/deck.gl#8960.

@kylebarron
Copy link
Member

9.0.23 was published with the fix for the heatmap layer so it looks like we should be able to upgrade to 9.x now!

@kylebarron
Copy link
Member

Well actually I'm getting the same error with the latest deck.gl 😔
image

I think we need to have a better way to generate pure-JS deck.gl snapshots so that we have minimal JS projects to create deck.gl issues.

@kylebarron
Copy link
Member

I think we need to have a better way to generate pure-JS deck.gl snapshots so that we have minimal JS projects to create deck.gl issues.

Created #573

kylebarron and others added 2 commits July 15, 2024 18:18
# Conflicts:
#	package-lock.json
#	package.json
#	src/index.tsx
#	src/model/layer.ts
@vgeorge
Copy link
Member Author

vgeorge commented Aug 7, 2024

@kylebarron it looks like @geoarrow/deck.gl-layers is using Deck.gl v9.0.12, which doesn't include the fix from visgl/deck.gl#8960. Could this be the reason the heatmap layer is not loading properly?

@kylebarron
Copy link
Member

@kylebarron it looks like @geoarrow/deck.gl-layers is using Deck.gl v9.0.12, which doesn't include the fix from visgl/deck.gl#8960. Could this be the reason the heatmap layer is not loading properly?

@geoarrow/deck.gl-layers only has a peer dependency on deck.gl: https://github.com/geoarrow/deck.gl-layers/blob/25fdeafe2d9c591570bab975ebea43ae82e97a8d/package.json#L46-L49

We can verify that the deck.gl version used in this branch is indeed 9.0.23:

lonboard/package-lock.json

Lines 1168 to 1169 in 44146ee

"node_modules/@deck.gl/core": {
"version": "9.0.23",

@kylebarron
Copy link
Member

I added a notice in the docs and a warning in user code that the HeatmapLayer does not currently work with deck.gl v9

@kylebarron kylebarron enabled auto-merge (squash) August 13, 2024 22:39
@kylebarron kylebarron enabled auto-merge (squash) August 13, 2024 22:41
@kylebarron kylebarron merged commit 08d6973 into main Aug 13, 2024
5 checks passed
@kylebarron kylebarron deleted the upgrade/deckgl-to-v9 branch August 13, 2024 22:43
@kylebarron
Copy link
Member

Thanks @vgeorge for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants