-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Deck.gl to version 9 #562
Conversation
Awesome! I'll take a look through some examples! |
Hmm it looks like the I would initially assume this is an upstream deck.gl bug. Ah yes, looks like we're hitting this: visgl/deck.gl#8960. |
9.0.23 was published with the fix for the heatmap layer so it looks like we should be able to upgrade to 9.x now! |
Created #573 |
# Conflicts: # package-lock.json # package.json # src/index.tsx # src/model/layer.ts
@kylebarron it looks like |
@geoarrow/deck.gl-layers only has a peer dependency on deck.gl: https://github.com/geoarrow/deck.gl-layers/blob/25fdeafe2d9c591570bab975ebea43ae82e97a8d/package.json#L46-L49 We can verify that the deck.gl version used in this branch is indeed 9.0.23: Lines 1168 to 1169 in 44146ee
|
I added a notice in the docs and a warning in user code that the HeatmapLayer does not currently work with deck.gl v9 |
Thanks @vgeorge for your help! |
Contributes to #422.
This is a work in progress. The
north-america-roads
example works and type checks pass, but I haven't been able to test this thoroughly yet.cc @kylebarron @batpad