Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build WHL file #40

Closed
wants to merge 4 commits into from
Closed

Build WHL file #40

wants to merge 4 commits into from

Conversation

Rub21
Copy link
Collaborator

@Rub21 Rub21 commented Nov 29, 2023

@Rub21 Rub21 requested a review from rbavery November 29, 2023 17:41
rbavery
rbavery reviewed Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@rbavery rbavery left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Ruben! I like installing from the src with hatch like this.

In the future maybe we can separate dev and prod images, where the Dockerfiles that run the services can instead install from pypi to simplify container setup.

Dockerfile-cpu Outdated Show resolved Hide resolved
Dockerfile-gpu Outdated Show resolved Hide resolved
@Rub21
Copy link
Collaborator Author

Rub21 commented Nov 29, 2023

yes, i think that something that we can do in the GitHub actions the way that creates the images, dev and prod

@rbavery rbavery self-requested a review November 29, 2023 19:17
rbavery
rbavery previously approved these changes Nov 29, 2023
View reviewed changes
@rbavery rbavery dismissed their stale review November 30, 2023 17:59

services aren't working

@Rub21 Rub21 closed this Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbavery rbavery rbavery left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rub21 @rbavery