fix: volumes object is always persists in dynamic objects #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
|
disyakidneyshot
suggested changes
Oct 3, 2023
| public volumesColorByChartTypeMap: Partial<Record<BarType, VolumeColorResolver>> = {}; | ||
| volumesModel: VolumesModel; | ||
| volumesDrawer: VolumesDrawer |
| @@ -23,8 +23,10 @@ export type VolumeColorResolver = (priceMovement: PriceMovement, colors: FullCha | |||
|
|
|||
| export class VolumesComponent extends ChartBaseElement { | |||
| separateVolumes: SeparateVolumesComponent; | |||
| dynamicObjectsComponent: DynamicObjectsComponent; | |||
There was a problem hiding this comment.
you can declare it via constructor in arguments using private keyword for example, and it will be the same but much less code
| private addVolumesToDynamicObjects() { | ||
| this.dynamicObjectsComponent.model.addObject({ | ||
| id: this.volumesModel.id, | ||
| paneId: this.config.components.volumes.showSeparately ? this.volumesModel.id : CHART_UUID, |
There was a problem hiding this comment.
are you sure paneId for separate volumes is this.volumesModel.id?
disyakidneyshot
approved these changes
Oct 4, 2023
disyakidneyshot
force-pushed
the
43-volumes-object-is-always-persists-in-dynamic-objects
branch
from
a232736 to
5ca273d
Compare
disyakidneyshot
deleted the
43-volumes-object-is-always-persists-in-dynamic-objects
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.