Add Personal Access Token As An Alternative Authentication Option #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a new `handleAuthError` function to centralize error handling for authentication failures, improving code readability and maintainability. - Updated the `LoginHelpersProvider` to utilize the new error handling function during OAuth execution and personal access token login. - Refactored the `onLoginRequest` saga to handle GraphQL errors more effectively, including detailed error responses. - Adjusted the `LoginScreen` to ensure proper support for personal access token login on all platforms. - Improved type safety by adding GraphQL error interfaces and enhancing existing type definitions. These changes aim to provide a more robust user experience during authentication processes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the issue described in #314, the production application is no longer usable.
As a workaround, I've implemented the capability to connect to GitHub via a Personal Access Token. IIRC, this may have been a capability earlier on but this approach was removed in favor of the current authentication method.
As a starting point, I put together this PR so you can use the app via a local development instance by running
yarn dev:desktop. This will open up the Electron application on your desktop and you can connect to GitHub with a Personal Access Token and use it.IMPORTANT NOTE: Since I do not have familiarity with this code base, I used the agent AI feature in Cursor to work through getting this to a working state. After a few tries and a bit of guidance, I was able to get this up and running locally with the changes in this PR. That being said, there may be better ways to go about some of the implementation and I'm happy to make any preferred adjustments. My main goal was to have it working so I could, at the very least, spin up a local instance and use the app!