Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop async-trait #355

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Drop async-trait #355

wants to merge 1 commit into from

Conversation

matze
Copy link

@matze matze commented Dec 10, 2023

This is a preview and in anticipation of Rust 1.75. But it works well with current nightly either. Note that the public trait API requires the desugared form in order to specify the Send bound on the returned future.

@qdot
Copy link
Contributor

qdot commented Dec 10, 2023

There's gonna be an interesting question about how far back w/ rust versions we want the library to be compatible, so I'm hesitant to merge this right after the 1.75 release (currently scheduled for 2023/12/28). That said, I'll definitely let this hang out and am looking forward to the feature going stable.

@matze
Copy link
Author

matze commented Dec 10, 2023

One option would be to make the async_trait macro usage be a default feature (for the foreseeable future) and when opted out switch to AFIT. But I can imagine that this looks rather ugly with lots of #[cfg(…)]s

@qwandor qwandor changed the base branch from master to dev December 10, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants