Skip to content

Commit

Permalink
[MM-53430] Don't stop the isDraftSubmitting flow when the notificat…
Browse files Browse the repository at this point in the history
…ion modal is popped (mattermost#23962)

* [MM-53430] Don't stop the `isDraftSubmitting` flow when the notification modal is popped

* Reset to false if the modal closes without confirming
  • Loading branch information
devinbinnie authored Jul 10, 2023
1 parent da3d5c7 commit 2abcdfe
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -475,6 +475,9 @@ class AdvancedCreateComment extends React.PureComponent<Props, State> {
channelTimezoneCount,
memberNotifyCount,
onConfirm: () => this.handleNotifyAllConfirmation(),
onExited: () => {
this.isDraftSubmitting = false;
},
},
});
};
Expand Down Expand Up @@ -650,7 +653,6 @@ class AdvancedCreateComment extends React.PureComponent<Props, State> {

if (memberNotifyCount > 0) {
this.showNotifyAllModal(mentions, channelTimezoneCount, memberNotifyCount);
this.isDraftSubmitting = false;
return;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -585,6 +585,9 @@ class AdvancedCreatePost extends React.PureComponent<Props, State> {
channelTimezoneCount,
memberNotifyCount,
onConfirm: () => this.handleNotifyAllConfirmation(),
onExited: () => {
this.isDraftSubmitting = false;
},
},
});
};
Expand Down Expand Up @@ -689,7 +692,6 @@ class AdvancedCreatePost extends React.PureComponent<Props, State> {
return;
} else if (memberNotifyCount > 0) {
this.showNotifyAllModal(mentions, channelTimezoneCount, memberNotifyCount);
this.isDraftSubmitting = false;
return;
}

Expand Down

0 comments on commit 2abcdfe

Please sign in to comment.