[MM-55165] Remove target=_blank from file preview links (mattermost#2…

…5317)
devinbinnie · Nov 9, 2023 · 8bf0c19 · 8bf0c19
1 parent dc269f2
commit 8bf0c19
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/...p/channels/src/components/file_info_preview/__snapshots__/file_info_preview.test.tsx.snap b/...p/channels/src/components/file_info_preview/__snapshots__/file_info_preview.test.tsx.snap
@@ -4,10 +4,9 @@ exports[`components/FileInfoPreview should match snapshot, can download files 1`
 <div
   className="file-details__container"
 >
-  <ExternalLink
+  <a
     className="file-details__preview"
     href="https://pre-release.mattermost.com/api/v4/files/rqir81f7a7ft8m6j6ej7g1txuo"
-    location="file_info_preview"
   >
     <span
       className="file-details__preview-helper"
@@ -16,7 +15,7 @@ exports[`components/FileInfoPreview should match snapshot, can download files 1`
       alt="file preview"
       src={null}
     />
-  </ExternalLink>
+  </a>
   <div
     className="file-details"
   >

diff --git a/webapp/channels/src/components/file_info_preview/file_info_preview.tsx b/webapp/channels/src/components/file_info_preview/file_info_preview.tsx
@@ -5,8 +5,6 @@ import React from 'react';
 
 import type {FileInfo} from '@mattermost/types/files';
 
-import ExternalLink from 'components/external_link';
-
 import * as Utils from 'utils/utils';
 
 type Props = {
@@ -36,17 +34,16 @@ export default class FileInfoPreview extends React.PureComponent<Props> {
         let preview = null;
         if (this.props.canDownloadFiles) {
             preview = (
-                <ExternalLink
+                <a
                     className='file-details__preview'
                     href={fileUrl}
-                    location='file_info_preview'
                 >
                     <span className='file-details__preview-helper'/>
                     <img
                         alt={'file preview'}
                         src={Utils.getFileIconPath(fileInfo)}
                     />
-                </ExternalLink>
+                </a>
             );
         } else {
             preview = (