compiler: Keep -qopenmp by default after icx 2023.2 #2164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mloubout
reviewed
Jul 20, 2023
Codecov Report
@@ Coverage Diff @@
## master #2164 +/- ##
==========================================
- Coverage 87.04% 87.04% -0.01%
==========================================
Files 223 223
Lines 39957 39962 +5
Branches 7295 7300 +5
==========================================
+ Hits 34781 34784 +3
- Misses 4597 4598 +1
- Partials 579 580 +1
|
georgebisbas
force-pushed
the
icx2023.2-qopenmp-fix
branch
from
80443f9
to
12180b3
Compare
devito/arch/compiler.py
Outdated
| if language == 'openmp': | ||
| # Since OneAPI 2023.2.0 (clang17 underneath), we can use '-qopenmp' | ||
| # for all our tests | ||
| if self.version >= Version('17.0.0') and language == 'openmp': |
There was a problem hiding this comment.
isn't this doing the opposite of what the comment says?
also, if you are to change this (maybe not, maybe I misunderstood...), could you drop "for all our tests" which doesn't mean much? what you should have said is that earlier versions have an OpenMP bug. The bug is in their compilers, it doesn't have anything to do with our tests (I mean, not directly)
There was a problem hiding this comment.
Ah sorry, you are right thanks!
georgebisbas
force-pushed
the
icx2023.2-qopenmp-fix
branch
from
12180b3
to
9d8e53b
Compare
FabioLuporini
approved these changes
Jul 21, 2023
mloubout
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passes locally
After icx 2023.2.0, reductions should are passing