compiler: fix non arithmetic distances #2165
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2165 +/- ##
=======================================
Coverage 87.04% 87.04%
=======================================
Files 223 223
Lines 39946 39957 +11
Branches 7295 7295
=======================================
+ Hits 34769 34781 +12
+ Misses 4598 4597 -1
Partials 579 579
|
| try: | ||
| ret[d][0] = min(ret[d][0], value) | ||
| ret[d][1] = max(ret[d][1], value) | ||
| except TypeError: |
There was a problem hiding this comment.
Interesting, why can we now end up here with SymPy?
There was a problem hiding this comment.
I mean SymPy 1.12 and not SymPy 1.11 for example
There was a problem hiding this comment.
Somehow previous versions end up with {0, expr} asv and therefore 0 as value but with sympy 1.12 you only get {expr} which breaks mon/max. Didn't look too deep into why though
There was a problem hiding this comment.
there might be a deeper issue then; are we now generating the same exact code for the MFE?
There was a problem hiding this comment.
We are we test all sympy version 1.9-1.12 that pass the same test
|
Thanks, merged |
Fix #2163