tests: Add a test-only init for issue 2448 #2465
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgebisbas
added
the
bug-C-minor
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2465 +/- ##
==========================================
- Coverage 87.06% 78.70% -8.37%
==========================================
Files 239 239
Lines 45123 45151 +28
Branches 8428 8430 +2
==========================================
- Hits 39286 35535 -3751
- Misses 5102 8825 +3723
- Partials 735 791 +56 ☔ View full report in Codecov by Sentry. |
FabioLuporini
added
bug-performance-C
and removed
bug-C-minor
EdCaunt
reviewed
Oct 11, 2024
|
|
||
| # First order elastic-like dependencies equations | ||
| pde_v = v.dt - (tau.dx) | ||
| pde_tau = (tau.dt - ((v.forward).dx)) |
There was a problem hiding this comment.
Nitpick: You don't need all these brackets right?
| pde_v = v.dt - (tau.dx) | ||
| pde_tau = (tau.dt - ((v.forward).dx)) | ||
|
|
||
| u_v = Eq(v.forward, solve(pde_v, v.forward)) |
There was a problem hiding this comment.
Does it work with just Eq(v.forward, tau.dx) and Eq(tau.forward, v.forward.dx)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the weekly meeting 24th of Sept.
#2448