-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dsl: Move SubDimension thickness evaluation to the thicknesses themselves #2470
base: master
Are you sure you want to change the base?
Changes from 13 commits
9b3cc39
c4df05f
754c5f0
c4f4c06
887288a
867b025
fbab5c9
8d80b2c
2eb5b0a
c8e3ef3
f533211
1360b6e
821f336
1d056ab
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,6 +31,8 @@ | |
split, timed_pass, timed_region, contains_val) | ||
from devito.types import (Buffer, Grid, Evaluable, host_layer, device_layer, | ||
disk_layer) | ||
from devito.types.dimension import SubDimensionThickness | ||
|
||
|
||
__all__ = ['Operator'] | ||
|
||
|
@@ -640,6 +642,11 @@ def _prepare_arguments(self, autotune=None, **kwargs): | |
for d in reversed(toposort): | ||
args.update(d._arg_values(self._dspace[d], grid, **kwargs)) | ||
|
||
# Process SubDimensionThicknesses | ||
for p in self.parameters: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this should be triggered from within There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No, the issue is that the |
||
if isinstance(p, SubDimensionThickness): | ||
args.update(p._arg_values(grid=grid, **kwargs)) | ||
|
||
# Process Objects | ||
for o in self.objects: | ||
args.update(o._arg_values(grid=grid, **kwargs)) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would avoid t0 and t1 due to name clash with time buffers.
It's not about correctness, but mostly when grepping