Ajout de la RTC #26
Open
Ajout de la RTC #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supercip971
requested changes
Apr 16, 2021
| ```c | ||
| unsigned char rtc_get_seconds() | ||
| { | ||
| unsigned char seconds = rtc_read(0); |
There was a problem hiding this comment.
peut être utilier une macro RTC_SECOND_REGISTER à la place de 0
src/x86_64/périphériques/RTC.md
Outdated
| while (rtc_is_updating()); | ||
| outb(0x70, reg); | ||
|
|
||
| return inb(0x71); |
There was a problem hiding this comment.
il faudrait mieux utiliser des registres à la place des valeurs magique comme 0x71 0x70...
Supercip971
requested changes
Apr 28, 2021
| @@ -13,19 +13,27 @@ Elle peut être utilisée pour avoir la date et heure précise. (voir ACPI pour | |||
| # Lire le temps | |||
| Il est possible de lire depuis la RTC en utilisant les fonctions suivantes: | |||
| ```c | |||
|
|
|||
| enum | |||
| { | |||
There was a problem hiding this comment.
in the documentation, put a markdown table instead of a C code enum, it's better for reading
There was a problem hiding this comment.
and add other register, like STATUS_REGISTER_B, week, day, hour, ... in the table (maybe ?)
| outb(0x70, 0x0A); | ||
| return inb(0x71) & 0x80; | ||
| outb(CMOS_ADDRESS, STATUS_REGISTER_A); | ||
| return inb(CMOS_DATA) & 0x80; |
There was a problem hiding this comment.
maybe add a signification of the last bit ?
|
is this pr still active ? |
|
up ? |
|
up :^( |
|
uwup ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
J'ai commencé un petit article sur la RTC, n'hésitez pas à me dire si je devrait ajouter quelque chose :)