Change behavior of simulateRemotePods to use the Pods API #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghostdogpr
commented
Sep 19, 2024
| @@ -13,7 +13,7 @@ val sttpVersion = "3.9.6" | |||
| val calibanVersion = "2.8.1" | |||
| val redis4catsVersion = "1.5.2" | |||
| val redissonVersion = "3.27.1" | |||
| val scalaKryoVersion = "1.0.2" | |||
| val scalaKryoVersion = "1.2.0" | |||
There was a problem hiding this comment.
They fixed an issue with the serialization of Scala 3 enums.
ghostdogpr
commented
Sep 19, 2024
| @@ -212,6 +212,13 @@ lazy val commonSettings = Def.settings( | |||
| "com.dimafeng" %% "testcontainers-scala-core" % testContainersVersion % Test | |||
| ), | |||
| Test / fork := true, | |||
| Test / javaOptions ++= Seq( | |||
| // Kryo requires this with the recent versions of Java | |||
| "--add-opens=java.base/java.util=ALL-UNNAMED", | |||
There was a problem hiding this comment.
Needed to serialize Exception which we do in tests.
ghostdogpr
commented
Sep 19, 2024
| stringClient.hSet(config.podsKey, pods.map { case (k, v) => k.toString -> v.version }).unit | ||
| stringClient | ||
| .hSet(config.podsKey, pods.map { case (k, v) => k.toString -> v.version }) | ||
| .when(pods.nonEmpty) |
There was a problem hiding this comment.
I found that this was failing when saving an empty list.
nox213
reviewed
Sep 19, 2024
nox213
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing option
simulateRemotePodswas only forcing serialization of sent messages but not responses. Instead, it is now using the actualPodsAPI when sending to a local shard which means it's going to go through the whole transport.