Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't rely on Ref.Synchronized for updating entity last use time #97

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Don't rely on Ref.Synchronized for updating entity last use time #97

merged 2 commits into from
Nov 1, 2023

Conversation

ghostdogpr
Copy link
Collaborator

Ref.Synchronized#modifyZIO was called for every message which is not very good for performance considering it uses a semaphone. We moved the last usage time of each entity into a separate Ref, and always use get before modifyZIO so that the happy path is fast.

@ghostdogpr ghostdogpr self-assigned this Nov 1, 2023
@ghostdogpr ghostdogpr merged commit a09d2e2 into series/2.x Nov 1, 2023
4 checks passed
@ghostdogpr ghostdogpr deleted the feature/optimistic branch November 1, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nox213 nox213 nox213 approved these changes

Assignees

@ghostdogpr ghostdogpr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghostdogpr @nox213