Create offline sessions if approval is skipped #3828
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Offline session is not created if the skip approval option is toggled. In this case Dex looses connector data and cannot refresh tokens.
It leads to the different refreshing errors in logs like:
What this PR does / why we need it
This PR adjust the part of the code to make it creating and updating connectorData when it is needed avoiding refresh errors.
Special notes for your reviewer