update ingress.yaml and service.yaml #124
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RadOctocode
force-pushed
the
fix/changes-to-dex-helm-chart
branch
2 times, most recently
from
38c7cee to
5a420f8
Compare
… suport specifying telemetry nodeport Signed-off-by: RadOctocode <[email protected]>
RadOctocode
force-pushed
the
fix/changes-to-dex-helm-chart
branch
from
5a420f8 to
e5ef199
Compare
|
@sagikazarmark can I get a review on this? |
r5sec5cyl
suggested changes
Mar 12, 2024
RadOctocode
force-pushed
the
fix/changes-to-dex-helm-chart
branch
from
c5052ad to
9bd4774
Compare
Signed-off-by: RadOctocode <[email protected]>
RadOctocode
force-pushed
the
fix/changes-to-dex-helm-chart
branch
from
9bd4774 to
d990358
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
updated imgress.yaml to allow https ports and updated service.yaml to support specifying telemetry nodeport
What this PR does / why we need it
It would be nice to support https ports and telemetry nodeports without having to manually patch the file ourselves
Special notes for your reviewer
Checklist
Chart.yaml(see the contributing guide for details)Chart.yaml(see the contributing guide for details)make docs