Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(charts/dex): add initContainers #135

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bdomars
Copy link

@bdomars bdomars commented Jul 12, 2024

Overview

Adding an option to specify initContainers via values.

What this PR does / why we need it

The use case I have for this is to be able to run a custom built image in an initContainer that will copy a custom theme into an emptyDir volume that is mounted by both the Dex container and the initContainer.

I've been doing something like this

initContainers:
- image: dex-custom-theme:v1
  imagePullPolicy: Always
  name: install-theme
  resources: {}
  volumeMounts:
  - mountPath: /custom-theme
    name: custom-theme
volumes:
- emptyDir: {}
  name: custom-theme
volumeMounts:
- mountPath: /custom-theme
  name: custom-theme
env:
  DEX_FRONTEND_DIR: /custom-theme

This allows to use a custom theme for Dex with the helm chart and without a need for rebuilding the Dex image. This simplifies automatic updates with things like Renovate.

Checklist

  • Change log updated in Chart.yaml (see the contributing guide for details)
  • Chart version bumped in Chart.yaml (see the contributing guide for details)
  • Documentation regenerated by running make docs

@bdomars bdomars force-pushed the add-init-containers branch from aee5bd9 to 9051fca Compare July 12, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant