Implemented bells #645
Open
Implemented bells #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently missing bell models and ringing through projectiles.
89 tasks
# Conflicts: # cmd/blockhash/main.go # server/world/sound/block.go
# Conflicts: # server/entity/item.go
|
This should also be ready for review now. |
DaPigGuy
requested review from
Sandertv and
DaPigGuy
and removed request for
Sandertv
DaPigGuy
reviewed
Dec 22, 2022
| ProjectileHit(w *world.World, e world.Entity, pos cube.Pos, face cube.Face) | ||
| } | ||
|
|
||
| // EntityEjector represents a block that ejects entities when they are inside it. |
There was a problem hiding this comment.
This doesn't seem accurate as it's the item entity that's implementing this...
# Conflicts: # server/entity/item.go # server/entity/projectile.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.