Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flight speed #917

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add flight speed #917

wants to merge 5 commits into from

Conversation

Sergittos
Copy link

No description provided.

Copy link
Member

@TwistedAsylumMC TwistedAsylumMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Aside from the one comment, would you also be willing to extend this to also send the player's speed in the UpdateAbilities packet, assuming that doesn't cause any extra issues just so we can eliminate the TODO completely. If it's not as simple then I'm happy to merge this after the type is changed.

server/session/controllable.go Outdated Show resolved Hide resolved
@Sergittos
Copy link
Author

Thanks for the PR! Aside from the one comment, would you also be willing to extend this to also send the player's speed in the UpdateAbilities packet, assuming that doesn't cause any extra issues just so we can eliminate the TODO completely. If it's not as simple then I'm happy to merge this after the type is changed.

Added it, after some tests it seems that the walk speed only modifies the player's fov.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants