Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repairing renv database and adding dfeshiny functionality #27

Merged
merged 4 commits into from
Feb 23, 2024
Merged

Conversation

rmbielby
Copy link
Contributor

Pull request overview

The app was throwing the following error on deploys:

── Deploying to server ─────────────────────────────────────────────────────────
Waiting for task: 1387423346
  error: Parsing manifest
## Begin Task Log ##############################################################
## End Task Log ################################################################
Error: Error: Unhandled Exception: child_task=1387423355 child_task_status=failed: Error parsing manifest: Unknown repository for package source: git
Execution halted
Error: Process completed with exit code 1.

Seemed to be down to a corrupted renv database, so I ran the following to clean it up:

renv::deactivate()
renv::init()
renv::update()
renv::snapshot()

Whilst I was in the repo, I also made some updates to bring in the latest standards on cookie consent and the support_panel.

Pull request checklist

Please check if your PR fulfils the following:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Tests have been run locally and are passing (run_tests_locally())
  • Code is styled according to tidyverse styling (checked locally with tidy_code())

@rmbielby rmbielby requested a review from hkeogan February 23, 2024 10:26
@@ -26,6 +26,13 @@
hide(id = "loading-content", anim = TRUE, animType = "fade")
show("app-content")

output$cookie_status <- dfeshiny::cookie_banner_server(
"cookies",
input_cookies = reactive(input$cookies),

Check warning

Code scanning / lintr

no visible global function definition for 'reactive' Warning

no visible global function definition for 'reactive'
@@ -26,6 +26,13 @@
hide(id = "loading-content", anim = TRUE, animType = "fade")
show("app-content")

output$cookie_status <- dfeshiny::cookie_banner_server(
"cookies",
input_cookies = reactive(input$cookies),

Check warning

Code scanning / lintr

no visible global function definition for 'reactive' Warning

no visible global function definition for 'reactive'
input_cookies = reactive(input$cookies),
input_clear = reactive(input$cookie_consent_clear),
parent_session = session,
google_analytics_key = google_analytics_key

Check warning

Code scanning / lintr

no visible binding for global variable 'google_analytics_key' Warning

no visible binding for global variable 'google_analytics_key'
tags$script(src = "cookie-consent.js")
),
dfe_cookie_script(),
cookie_banner_ui("cookies", name = "Further Education Outcomes Industry Dashboard"),

Check notice

Code scanning / lintr

Lines should not be more than 80 characters. This line is 88 characters. Note

Lines should not be more than 80 characters. This line is 88 characters.
support_links()
dfeshiny::support_panel(
team_email = "[email protected]",
form_url = "https://forms.office.com/Pages/ResponsePage.aspx?id=yXfS-grGoU2187O4s0qC-YHar1nqsS9Eu7bHka6oC0lUQUlDNzNBVzdGSUE3VVpJMlY1STVTSjNVNC4u",

Check notice

Code scanning / lintr

Lines should not be more than 80 characters. This line is 154 characters. Note

Lines should not be more than 80 characters. This line is 154 characters.
@hkeogan hkeogan merged commit 0520d85 into main Feb 23, 2024
5 checks passed
@hkeogan hkeogan deleted the development branch February 23, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants