-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repairing renv database and adding dfeshiny functionality #27
Conversation
@@ -26,6 +26,13 @@ | |||
hide(id = "loading-content", anim = TRUE, animType = "fade") | |||
show("app-content") | |||
|
|||
output$cookie_status <- dfeshiny::cookie_banner_server( | |||
"cookies", | |||
input_cookies = reactive(input$cookies), |
Check warning
Code scanning / lintr
no visible global function definition for 'reactive' Warning
@@ -26,6 +26,13 @@ | |||
hide(id = "loading-content", anim = TRUE, animType = "fade") | |||
show("app-content") | |||
|
|||
output$cookie_status <- dfeshiny::cookie_banner_server( | |||
"cookies", | |||
input_cookies = reactive(input$cookies), |
Check warning
Code scanning / lintr
no visible global function definition for 'reactive' Warning
input_cookies = reactive(input$cookies), | ||
input_clear = reactive(input$cookie_consent_clear), | ||
parent_session = session, | ||
google_analytics_key = google_analytics_key |
Check warning
Code scanning / lintr
no visible binding for global variable 'google_analytics_key' Warning
tags$script(src = "cookie-consent.js") | ||
), | ||
dfe_cookie_script(), | ||
cookie_banner_ui("cookies", name = "Further Education Outcomes Industry Dashboard"), |
Check notice
Code scanning / lintr
Lines should not be more than 80 characters. This line is 88 characters. Note
support_links() | ||
dfeshiny::support_panel( | ||
team_email = "[email protected]", | ||
form_url = "https://forms.office.com/Pages/ResponsePage.aspx?id=yXfS-grGoU2187O4s0qC-YHar1nqsS9Eu7bHka6oC0lUQUlDNzNBVzdGSUE3VVpJMlY1STVTSjNVNC4u", |
Check notice
Code scanning / lintr
Lines should not be more than 80 characters. This line is 154 characters. Note
Pull request overview
The app was throwing the following error on deploys:
Seemed to be down to a corrupted renv database, so I ran the following to clean it up:
Whilst I was in the repo, I also made some updates to bring in the latest standards on cookie consent and the support_panel.
Pull request checklist
Please check if your PR fulfils the following:
run_tests_locally()
)tidy_code()
)