Updated default dp for pretty_num #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reverted tests for pretty_num to og ones and added more tests in pretty_num amended tests in pretty_num table updated documentation
cjrace
requested changes
Oct 16, 2024
mzayeddfe
added a commit
that referenced
this pull request
Oct 18, 2024
* Create pretty table (#91) * added suggested solution for pretty_table after testing it and adding more comments * modified function so it doesn't just take numeric cols so it's more flexible added tests but still need to add more to them * changed the code to account for using the latest version of pretty_num * Improve pretty num (#89) (#90) * added nsmall args to pretty_num and comma_sep to allow formatting of decimals * amended the function so it takes multiple values * updated documenation * fixed the issue with negative dp being passed to nsmall * changed code for testing pretty_num * amended the documentation for comma_sep and changed expected_error to expect_equal in test_pretty_num * fixed the - dp args problem added nsmall to the documentation fixed the lintr styling and complexity errors * added extra tests to pretty_num * fixing formtting issues for lint testing * adding documentation, testing and extra comments for pretty_table an extra documentation line for pretty_num came up when running workflows * fixing the example for pretty_table by adding export * amended the documentation to pretty_table to remove refs to the cols just being numeric, add link to the function family and linked the pretty_num function * improved the documentation * changed function name added data frame test changed the no rows from a warning to a stop updated documentation * updated package version, gave details on what was changed in the news.md and added myself to ctb in the description file * fixed the bracket mistake in description, put nsmall is code format and updated documentations * updated the descriptions file so that i'm no longer stealing rich's academic code * Updated default dp for pretty_num (#93) * updated the dp default to be 0 reverted tests for pretty_num to og ones and added more tests in pretty_num amended tests in pretty_num table updated documentation * applying changes to code style to pass lint check * updated documentation * updated formatting of documentation for spelling * more updates to the documentation before updating package versions * updated documentation and readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief overview of changes
Why are these changes being made?
To stop the change in behaviour in pretty_num in the v0.6.0. This bug forces 2 dp by default.
Detailed description of changes
Issue ticket number/s and link
92