-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix external link not hidden #48
Conversation
…ng the cookies name match so snapshots match up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not spent a huge amount of time looking at every line of code but I have tested that everything works as it should 😄 thanks for the documentation updates!
Done a quick double check on the zzz.R thing and that is definitely a standard - https://r-pkgs.org/Code.html#when-you-do-need-side-effects
|
Brief overview of changes
After releasing the last version with
external_link()
we found a couple of bugs with the add_warning = FALSE version of the link.Why are these changes being made?
Hidden text was not being hidden. Excess whitespace was being added. We had missed this in the tests.
Detailed description of changes
Additional information for reviewers
zzz.R is apparently a specific standard file name for that kind of on package load function. shinyGovstyle uses and copilot independently also said this was the case (which was enough for me to just do it, feel free to verify this further!).
Issue ticket number/s and link
#47