Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling refresh of disconnect dialogue #61

Merged
merged 6 commits into from
Oct 25, 2024

Conversation

rmbielby
Copy link
Contributor

Brief overview of changes

I've adapted the disconnect dialogue box to make it a little more user friendly;

  • more GDS consistent styling
  • clearer, less jargony text
  • aria labelling

Why are these changes being made?

CSC team suggested some changes to the disconnect message dialogue box to make it less imposing for users:

  • Nicer colour scheme
  • Less technical text (e.g. mirror etc)

Detailed description of changes

  • Replaced message text with something a little clearer.
  • Updated css to be more GDS consistent - white box with a focus-yellow border
  • I've shifted the css to be attached within the package itself rather than relying on the contents of dfe_shiny_gov_style.css
  • Pointing to an EES publication is now optional (the CSC dashboard and some others collate data from across several EES and non-EES data sources, so offering to send the user to EES or a single publication EES doesn't work in this context)
image

Additional information for reviewers

We may need / want to clear out the old css from the copied dfe_shiny_gov_style.css files some dashboards.

Issue ticket number/s and link

...

@rmbielby rmbielby requested a review from cjrace October 25, 2024 11:31
@rmbielby rmbielby self-assigned this Oct 25, 2024
R/custom_disconnect_message.R Fixed Show fixed Hide fixed
R/custom_disconnect_message.R Fixed Show fixed Hide fixed
Copy link
Contributor

@cjrace cjrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of linting issues from lintr and then extra comments from me.

Also probably worth adding some testing on the HTML output, so checking things like the aria role is set right, the links pull through and are in the position expected etc?

This also should resolve #32 - so should either link that or mention it's fixed / resolved in the description

R/custom_disconnect_message.R Show resolved Hide resolved
R/custom_disconnect_message.R Show resolved Hide resolved
R/custom_disconnect_message.R Show resolved Hide resolved
inst/www/css/disconnect-dialogue.css Outdated Show resolved Hide resolved
inst/www/css/disconnect-dialogue.css Outdated Show resolved Hide resolved
Copy link
Contributor

@cjrace cjrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve, want to do it as a patch version update?

@rmbielby rmbielby merged commit bff6fef into main Oct 25, 2024
10 checks passed
@rmbielby rmbielby deleted the enhancement/disconnect-gds-restyle branch October 25, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants