-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Styling refresh of disconnect dialogue #61
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of linting issues from lintr and then extra comments from me.
Also probably worth adding some testing on the HTML output, so checking things like the aria role is set right, the links pull through and are in the position expected etc?
This also should resolve #32 - so should either link that or mention it's fixed / resolved in the description
…ion for some of the disconnect message links
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to approve, want to do it as a patch version update?
Brief overview of changes
I've adapted the disconnect dialogue box to make it a little more user friendly;
Why are these changes being made?
CSC team suggested some changes to the disconnect message dialogue box to make it less imposing for users:
Detailed description of changes
Additional information for reviewers
We may need / want to clear out the old css from the copied dfe_shiny_gov_style.css files some dashboards.
Issue ticket number/s and link
...