Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dfeshiny header #62

Merged
merged 6 commits into from
Nov 21, 2024
Merged

Dfeshiny header #62

merged 6 commits into from
Nov 21, 2024

Conversation

mzayeddfe
Copy link
Contributor

Brief overview of changes

  • Created a wrapper for the shinyGovstyle() function
  • Corrected documentation for support_panel()
    • not related to this issue but it kept popping up as an error when trying to create documentation for this function
    • "seealso [htmltool::tagList()]" was changed to "seealso [htmltools::tagList()]"

Why are these changes being made?

To make it easier to change header logos in repos without having to do it individually.

Detailed description of changes

The logo is automatically used with the specified width and height by calculating a scale for a height of 32 for the banner.

Issue ticket number/s and link

57

@rmbielby rmbielby self-requested a review November 14, 2024 11:44
@rmbielby rmbielby self-assigned this Nov 14, 2024
Copy link
Contributor

@rmbielby rmbielby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions inline on the params and a bit of scope creep (sorry!).

Additional thing not in the inline comments is that I feel like we need to add a demo of the header function in the test dashboard in tests/test_dashboard/.

R/header.R Show resolved Hide resolved
R/header.R Outdated Show resolved Hide resolved
@mzayeddfe mzayeddfe requested a review from rmbielby November 18, 2024 14:21
@mzayeddfe mzayeddfe merged commit ceab34a into main Nov 21, 2024
10 checks passed
@mzayeddfe mzayeddfe deleted the dfeshiny-header branch November 21, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants