Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial commit of bookmark script for bookmark include instead of exc… #69
base: main
Are you sure you want to change the base?
initial commit of bookmark script for bookmark include instead of exc… #69
Changes from 2 commits
7648d74
850b990
c1732b1
076d6dc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 31 in R/bookmark.R
Codecov / codecov/patch
R/bookmark.R#L31
Check warning on line 37 in R/bookmark.R
Codecov / codecov/patch
R/bookmark.R#L37
Check warning
Code scanning / lintr
no visible global function definition for 'setBookmarkExclude' Warning
Check warning
Code scanning / lintr
no visible binding for global variable 'toExclude' Warning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you've switched from to_exclude to toExclude here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, can you call functions explicitly, so in this case
shiny::setBookmarkExclude(...)
Check warning on line 39 in R/bookmark.R
Codecov / codecov/patch
R/bookmark.R#L39
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should use
message()
,warning()
etc rather thanprint()
wherever possibleCheck warning on line 41 in R/bookmark.R
Codecov / codecov/patch
R/bookmark.R#L41
Check warning
Code scanning / lintr
no visible binding for global variable 'session' Warning