EES-5740 Changes in response to PR comments

dfe-analytical-services · Dec 31, 2024 · 7035c31 · 7035c31
1 parent a0778c3
commit 7035c31
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/GovUk.Education.ExploreEducationStatistics.Data.Processor/Services/DataImportService.cs b/src/GovUk.Education.ExploreEducationStatistics.Data.Processor/Services/DataImportService.cs
@@ -275,7 +275,8 @@ private static async Task<DataSetFileFilterHierarchy> GenerateFilterHierarchy(
             var childFilter = filters
                 .Single(f => f.GroupCsvColumn == parentFilter.ColumnName);
 
-            while (true) // one iteration of loop per tier
+            // Loop over each parent/child or tier, starting with the root filter, until no child is found
+            while (true)
             {
                 var currentParentFilterId = parentFilter.Id; // avoid closure madness
                 var currentChildFilterId = childFilter.Id;

diff --git a/src/GovUk.Education.ExploreEducationStatistics.Data.ViewModels/Meta/SubjectMetaViewModel.cs b/src/GovUk.Education.ExploreEducationStatistics.Data.ViewModels/Meta/SubjectMetaViewModel.cs
@@ -12,5 +12,5 @@ public record SubjectMetaViewModel
 
     public TimePeriodsMetaViewModel TimePeriod { get; set; } = new();
 
-    public List<DataSetFileFilterHierarchyViewModel>? FilterHierarchies { get; set; } = null;
+    public List<DataSetFileFilterHierarchyViewModel>? FilterHierarchies { get; set; }
 }