EES-5542 Maps fetching/rendering boundaries for datasets #5423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennettstuart
requested review from
amyb-hiveit and
ntsim
and removed request for
amyb-hiveit
ntsim
requested changes
Dec 11, 2024
src/explore-education-statistics-common/src/modules/charts/components/MapBlock.tsx
Outdated
Show resolved
Hide resolved
src/explore-education-statistics-common/src/modules/charts/components/MapBlock.tsx
Outdated
Show resolved
Hide resolved
src/explore-education-statistics-common/src/modules/charts/components/MapBlock.tsx
Show resolved
Hide resolved
src/explore-education-statistics-common/src/modules/charts/components/MapBlock.tsx
Outdated
Show resolved
Hide resolved
src/explore-education-statistics-common/src/modules/charts/components/MapGeoJSON.tsx
Outdated
Show resolved
Hide resolved
src/explore-education-statistics-common/src/modules/table-tool/utils/mapFullTableMeta.ts
Outdated
Show resolved
Hide resolved
...xplore-education-statistics-common/src/modules/charts/components/__tests__/MapBlock.test.tsx
Show resolved
Hide resolved
...xplore-education-statistics-common/src/modules/charts/components/__tests__/MapBlock.test.tsx
Outdated
Show resolved
Hide resolved
...xplore-education-statistics-common/src/modules/charts/components/__tests__/MapBlock.test.tsx
Outdated
Show resolved
Hide resolved
...xplore-education-statistics-common/src/modules/charts/components/__tests__/MapBlock.test.tsx
Outdated
Show resolved
Hide resolved
ntsim
reviewed
Dec 11, 2024
src/explore-education-statistics-common/src/modules/charts/components/ChartRenderer.tsx
Outdated
Show resolved
Hide resolved
bennettstuart
force-pushed
the
EES-5542
branch
3 times, most recently
from
3122129 to
c0c6c08
Compare
bennettstuart
force-pushed
the
EES-5542
branch
7 times, most recently
from
8255bad to
8cd2437
Compare
ntsim
requested changes
Jan 7, 2025
There was a problem hiding this comment.
Looks like some of your tests are failing as well. Seems like there's some errors around a missing intersection observer.
I've added the intersection-observer polyfill to fix this in the #5502 PR (which fixes the react-leaflet problem) that is targeting your branch.
...re-education-statistics-admin/src/pages/release/datablocks/components/chart/ChartBuilder.tsx
Outdated
Show resolved
Hide resolved
| @@ -361,6 +361,7 @@ describe('ChartBuilder', () => { | |||
|
|
|||
| test('calls `onTableQueryUpdate` when change boundary level', async () => { | |||
| const testInitialChart: Chart = { | |||
| onBoundaryLevelChange: jest.fn(), | |||
There was a problem hiding this comment.
onBoundaryLevelChange shouldn't be on the Chart type as it's just supposed to be the chart's JSON configuration from the API.
We should omit this from Chart using Omit (not OmitStrict) and remove this from all relevant places in this PR where it's been added so far.
src/explore-education-statistics-common/src/modules/charts/components/MapBlock.tsx
Outdated
Show resolved
Hide resolved
src/explore-education-statistics-common/src/modules/charts/components/MapBlock.tsx
Outdated
Show resolved
Hide resolved
src/explore-education-statistics-common/src/modules/charts/components/MapBlock.tsx
Outdated
Show resolved
Hide resolved
...on-statistics-common/src/modules/find-statistics/components/__tests__/DataBlockTabs.test.tsx
Outdated
Show resolved
Hide resolved
...on-statistics-common/src/modules/find-statistics/components/__tests__/DataBlockTabs.test.tsx
Outdated
Show resolved
Hide resolved
...on-statistics-common/src/modules/find-statistics/components/__tests__/DataBlockTabs.test.tsx
Outdated
Show resolved
Hide resolved
...on-statistics-common/src/modules/find-statistics/components/__tests__/DataBlockTabs.test.tsx
Outdated
Show resolved
Hide resolved
...on-statistics-common/src/modules/find-statistics/components/__tests__/DataBlockTabs.test.tsx
Outdated
Show resolved
Hide resolved
bennettstuart
force-pushed
the
EES-5542
branch
2 times, most recently
from
a426f0f to
8a047c0
Compare
…onents with callbacks
…ove map component
…red map data set options
…ucation-statistics-common'
bennettstuart
force-pushed
the
EES-5542
branch
from
bfaf7ae to
402eed3
Compare
bennettstuart
force-pushed
the
EES-5542
branch
2 times, most recently
from
5292182 to
19506c4
Compare
bennettstuart
force-pushed
the
EES-5542
branch
from
19506c4 to
57708ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting map charts to fetch location geo JSON for data sets with boundary levels set.
This has been setup by:
releaseId&dataBlockParentIdprops into MapBlockuseQueryto handle fetching location geo JSON based on data set input selectionuseQuerycache is initialised with existing subject meta location data to avoid duplicate callsuseQueryas it stands and is set to not refetch on alt-tab or stale data, as the response is extremely unlikely to change