-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EES-5656 Allow custom ordering of a publication's latest release when reordering releases #5455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-hive
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks great! :D
jack-hive
approved these changes
Dec 12, 2024
benoutram
force-pushed
the
EES-5656_Release_Series_Change
branch
from
December 16, 2024 17:37
503277b
to
2634134
Compare
…ed on the latest release with a published version
…edReleaseVersion_SkipsUnpublishedReleases and reduce level of detail checked in UpdateReleaseSeries_UpdatesLatestPublishedReleaseVersion
benoutram
force-pushed
the
EES-5656_Release_Series_Change
branch
from
December 20, 2024 11:20
2634134
to
9787a3d
Compare
…s dependent on the value of `publishedOnly`
…test release page
…l to not use method ListLatestPublishedReleaseVersions
…blishedReleaseVersions
…blishedReleaseVersionIds and ListLatestReleaseVersions/ListLatestPublishedReleaseVersions with new publishedOnly flag.
…leaseVersion(Guid publicationId)
…ReleaseVersion(Guid publicationId)
…hedReleaseVersion(Guid publicationId)
…lishedReleaseVersion(Guid publicationId)
…ersion for publication based on the latest release with a published version
…ublishedReleaseVersionByReleaseSlug
…ods to use release series when working out the latest published release version of publication
…hing_Change EES-5656 Publishing change
Updated UI test report after merging in #5474 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds upon the changes already made for EES-5656 in #5441, #5442 and #5444.
It allows custom ordering of a publication's latest release in the Admin's 'Release order' page when reordering releases.
With this change it's now possible to alter which the latest published release for a publication should be by ordering that release as the top release in the list after any unpublished or legacy releases.
A backend change has been made so that when reordering the releases, the publication's
LatestPublishedReleaseVersionId
value is worked out to be the latest published version of the first release in the reordered list of releases which has a published version (if any).The remaining work in EES-5656 (to follow) will alter the publishing workflow to change
LatestPublishedReleaseVersionId
accordingly if a release version being published belongs to the latest release in the publication's release order.Until that change has been it's possible that publishing another release version can revert an update made to the publication by the 'Release order' page so I'm marking this PR as 'Do not merge' for now.
ℹ️ ℹ️ Update 20/12/24: #5474 has now been merged into this change. ℹ️ ℹ️
Other changes
PublicationService
to use primary constructor.UI test result
release_reordering.robot: