Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EES-5656 Allow custom ordering of a publication's latest release when reordering releases #5455

Merged
merged 22 commits into from
Dec 20, 2024

Conversation

benoutram
Copy link
Collaborator

@benoutram benoutram commented Dec 12, 2024

This PR builds upon the changes already made for EES-5656 in #5441, #5442 and #5444.

It allows custom ordering of a publication's latest release in the Admin's 'Release order' page when reordering releases.

With this change it's now possible to alter which the latest published release for a publication should be by ordering that release as the top release in the list after any unpublished or legacy releases.

A backend change has been made so that when reordering the releases, the publication's LatestPublishedReleaseVersionId value is worked out to be the latest published version of the first release in the reordered list of releases which has a published version (if any).

The remaining work in EES-5656 (to follow) will alter the publishing workflow to change LatestPublishedReleaseVersionId accordingly if a release version being published belongs to the latest release in the publication's release order.

Until that change has been it's possible that publishing another release version can revert an update made to the publication by the 'Release order' page so I'm marking this PR as 'Do not merge' for now.

ℹ️ ℹ️ Update 20/12/24: #5474 has now been merged into this change. ℹ️ ℹ️

Other changes

  • Changed PublicationService to use primary constructor.

UI test result

release_reordering.robot:

image

@benoutram benoutram added the do not merge Don't merge just yet label Dec 12, 2024
Copy link
Collaborator

@jack-hive jack-hive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks great! :D

@benoutram benoutram force-pushed the EES-5656_Release_Series_Change branch from 503277b to 2634134 Compare December 16, 2024 17:37
@benoutram benoutram force-pushed the EES-5656_Release_Series_Change branch from 2634134 to 9787a3d Compare December 20, 2024 11:20
…l to not use method ListLatestPublishedReleaseVersions
…blishedReleaseVersionIds and ListLatestReleaseVersions/ListLatestPublishedReleaseVersions with new publishedOnly flag.
…ersion for publication based on the latest release with a published version
…ods to use release series when working out the latest published release version of publication
@benoutram benoutram removed the do not merge Don't merge just yet label Dec 20, 2024
@benoutram
Copy link
Collaborator Author

Updated UI test report after merging in #5474

image

@benoutram benoutram merged commit 2f093cc into dev Dec 20, 2024
8 checks passed
@benoutram benoutram deleted the EES-5656_Release_Series_Change branch December 20, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants