EES-5627 Adding Label to the Release
#5457
Conversation
| table: "Releases", | ||
| columns: new[] { "PublicationId", "Year", "TimePeriodCoverage", "Label" }, | ||
| unique: true, | ||
| filter: "[Label] IS NOT NULL"); |
There was a problem hiding this comment.
Out of interest, does this unique constraint still take effect for the combination of PublicationId, Year and TimePeriodCoverage when Label IS null? We'd hope it does! 🙂
There was a problem hiding this comment.
I would hope so! I'll double check
There was a problem hiding this comment.
I've fixed this with adding HasFilter(null) to the configuration for the index
There was a problem hiding this comment.
I wasn't sure how the null filter applied by the code HasFilter(null) is getting related specifically to the Label column.
I think the documentation here covers this. It says
When using the SQL Server provider EF adds an 'IS NOT NULL' filter for all nullable columns that are part of a unique index. To override this convention you can supply a null value.
So I think the answer is that it's probably not exclusive to the Label column, and would be applicable to other nullable columns if there were any.
There was a problem hiding this comment.
That's correct yes, that's also what I found :)
This PR adds a new optional
Labeldatabase column to theRelease.It has been set to have a max character limit of
50.The plan is, in a subsequent PR, to change how we calculate the
Slugfor aReleasesuch that it appends thisLabelto the end, prefixed with a-. For this reason, the character limit of theSlughas been extended by51.As part of this, we have changed the existing unique index that exists on the
PublicationId/Year/TimePeriodCoveragecolumns, and have added theLabelto the mix.Other Changes
Labelin theReleaseGeneratorExtensionsin the spirit of avoiding conflicts in some further work that might be coming along at the same time (namely, EES-5628 and EES-5634)