EES-5732 prevent ui test failures after data replacement #5460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyb-hiveit
requested review from
benoutram,
ntsim,
duncan-at-hiveit,
bennettstuart,
mmyoungman,
rianski,
tomjonesdev,
N-moh and
jack-hive
N-moh
approved these changes
Dec 12, 2024
bennettstuart
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
data_reordering.robotis currently failing when it tries to go back to the 'Data and Files' tab after replacing the data files.It errors because a request to the data file permissions endpoint fails because it uses the previous file id (from before the data was replaced). I can't replicate this manually at all so my guess is it's related to the speed of the UI tests.
This adds a check to
handleStatusChangeto check that the file still exists before calling the permissions service.There might well be a better way to fix this. I initially tried adding a short
sleepbefore clicking the 'Data and Files' tab but it didn't help.