EES-5580 validate EditableContentForm on submit after reinitialisation #5476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyb-hiveit
requested review from
benoutram,
ntsim,
duncan-at-hiveit,
bennettstuart,
mmyoungman,
rianski,
tomjonesdev and
jack-hive
bennettstuart
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where it was possible to save inaccessible content in release content by switching to the preview view and back.
The custom accessibility validation relies on
elementsfrom the CKEditor content being available, it's setonChangebut this isn't triggered when the form is reinitialised after switching back from preview mode. I've updated the form tosetElementsononElementsReadyas well which is triggered on reinitialisaiton.