Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EES-5662 Fix public API docs URLs on API quick start guide #5480

Open
wants to merge 3 commits into
base: ees-5396
Choose a base branch
from
Open

EES-5662 Fix public API docs URLs on API quick start guide #5480

wants to merge 3 commits into from

Conversation

ntsim
Copy link
Collaborator

@ntsim ntsim commented Dec 19, 2024 •
edited
Loading

⚠️ Depends on #5445 ⚠️

This PR fixes the links to the public API docs on the API quick start guide of each API data set (in the public frontend).

The previously broken links also helped make it apparent that we:

  • Aren't handling 404s and allow the generic Azure 404 page to render
  • Dobn't redirect to paths with trailing slashes (which causes broken assets and relative links)

We've now addressed both of these issues by:

  • Adding a custom 404 page which we've configured through staticwebapp.config.json
  • Adding an automatic trailing slash redirection, also through staticwebapp.config.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duncan-at-hiveit duncan-at-hiveit duncan-at-hiveit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ntsim @duncan-at-hiveit