EES-5707 Remove geojson cache file after updating data block with map #5516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoutram
approved these changes
Jan 10, 2025
Comment on lines
+237
to
+238
| await _cacheService.DeleteItemAsync( | ||
| new LocationsForDataBlockCacheKey(dataBlockVersion, mapChart.BoundaryLevel)); |
There was a problem hiding this comment.
Just wondering if there are any other places we should be invalidating the geojson cache, like if the data is replaced?
There was a problem hiding this comment.
Discussed this with Ben and Cam on Slack. We think the geojson cache isn't being invalidated for replacements, but we think that probably isn't an issue. We decided to not do anything about replacements immediately and highlight this case for testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes associated geo json cache files (controlled by
LocationsForDataBlockCacheKey) after a data block is updated.This is to prevent a bug where if someone caches geo json for a data set that has two locations with the same name, and then update the data block to include both locations of the same name, the user won't be able to look at the data block chart without getting a Sorry page. This would continue until the cache file had been removed. See EES-5704 for details.
This hasn't solved the issue entirely - if you update a data block the Content page may still lead to a Sorry page, but refreshing the page will fix this. This has been deemed acceptable for now.