Usr testing fixes #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o geog - sort order in fn
…o more modularised to get download to work)
…ausing incorrect geogs to show as options
…d input values so that they are not lost when changing page (means SN and Region do not share for charts)
…ables to allow other geog selections to populate
…t from download module so tables cna be downloaded straight away
…shots of LA charts
… across LA page too
…f these to the labs in custom_theme
…keep each unit on each line
…sed focus thickness too
… that have no polarity
… applied to stat neigh
…numeric date, updated test for this too
…re streamlined JS for this
…h duplicates in create own charts
…was not reacting (NOT IDEAL)
18 tasks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
PR to address issue #36
Pull request checklist
Please check if your PR fulfills the following:
shinytest2::test_app())styler::style_dir()andlintr::lint_dir())What is the current behaviour?
Number of small fixes (colours of charts) and additional functionality needs implementing (download buttons).
What is the new behaviour?
Almost all things raised in issue #36 addressed. I've left the remaining few as these are extra functionality that will need development time and should have their priority considered alongside other functionality.
Anything else