Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltips flags #38

Merged
merged 42 commits into from
Nov 19, 2024
Merged

Tooltips flags #38

merged 42 commits into from
Nov 19, 2024

Conversation

JT-39
Copy link
Contributor

@JT-39 JT-39 commented Nov 19, 2024

Pull request overview

Several small UI and back-end improvements added to the app.

Pull request checklist

Please check if your PR fulfills the following:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Tests have been run locally and are passing (shinytest2::test_app())
  • Code is styled according to tidyverse styling (checked locally with styler::style_dir() and lintr::lint_dir())

What is the current behaviour?

No errors, just a number of small improvements added to the app.

What is the new behaviour?

Here is a list of improvements made:

  • Tooltips added for the Trend and Rank (Rank still needs confirming)
  • Clearer and accurate Quartile Bands
  • Fixed colour error in Trend (no change appearing as red)
  • Adding spinners to tables and charts
  • Notification pointing to GitHub for full dataset on the Create Own page
  • Updated BDS and added a .csv version to repo for users to download
  • Changed user created NAs in Create Your Own table to ""
  • Quartile Band text colour is now white (for those coloured)
  • Adding COVID flags in plots
  • Fixed issue in staging table where if user created NAs in the initial query this wouldn't show.

Anything else

Maybe look into adding the COVID flag into the chart tooltips (currently showing as NA).

JT-39 added 30 commits November 12, 2024 15:58
…removed some unecessary code fromLA workshop
@JT-39 JT-39 merged commit 3db9701 into main Nov 19, 2024
3 checks passed
@JT-39 JT-39 deleted the tooltips-flags branch November 19, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant