Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltips fixes post bh #47

Merged
merged 16 commits into from
Nov 28, 2024
Merged

Tooltips fixes post bh #47

merged 16 commits into from
Nov 28, 2024

Conversation

JT-39
Copy link
Contributor

@JT-39 JT-39 commented Nov 28, 2024

Pull request overview

Minor fixes and adding extra tooltips after final QA pre development testing.

Pull request checklist

Please check if your PR fulfills the following:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Tests have been run locally and are passing (shinytest2::test_app())
  • Code is styled according to tidyverse styling (checked locally with styler::style_dir() and lintr::lint_dir())

What is the current behaviour?

Minor fixes and additional tooltips:

  • LA and indicator inputs are not loading in correctly from the bookmarking URL.
  • All topics indicator list is still in old order (of topics),
  • Want the default topic to be "Health and Wellbeing" akin to the original LAIT.
  • In Create Your Own the COVID missing years is being applied across all indicators (so appearing for those with no missing years).
  • Tooltips needed to explain that users can scroll or type to find selections.
  • Similarly for Year Range tooltip needed to explain the selections will show data from and to the years selected.
  • Create Your Own output table should have a tooltip to explain who it is populated.

What is the new behaviour?

List of changes:

  • Now each pages inputs for LA and indicator are being saved in the bookmarking URL (there is a tiny delay (150ms) between the updating of one pages inputs and the other - unlikely user will copy the URL that fast... but could be improved).
  • Indicators now in alphabetical order for "All topics" selection (where A to Z is first then special characters).
  • Having "Health and Wellbeing" as the default topic is not easily feasible due to the bookmarking meaning that an indicator from any topic can be loaded in, which can mismatch "Health and Wellbeing", so decision is to keep "All Topics" as default for now.
  • New method to locate and apply the COVID missing years which involves a join by indicator on the missing year.
  • Tooltips improved by using bslib::tooltip().
  • Applied tooltips as described above and changed the text in brackets on the Create Your Own page to tooltips too.
  • Placeholders have been added for the multi-choice charts and made consistent across pages (this too for the tooltips, such as removing full stops).
  • Tests amended for new default indicator.

Anything else

JT-39 added 16 commits November 27, 2024 11:54
…ght year for the covid NA years (mainly for Create Your Own plots)
…te Your Own placeholder to suggest multiple selections
@JT-39 JT-39 merged commit 73e8d43 into main Nov 28, 2024
3 checks passed
@JT-39 JT-39 deleted the tooltips-fixes-post-bh branch November 28, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant