Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Removing american Zs #71

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Fix: Removing american Zs #71

merged 2 commits into from
Jan 9, 2025

Conversation

JT-39
Copy link
Contributor

@JT-39 JT-39 commented Jan 6, 2025

Pull request overview

There are some words which have the American spelling of using a "z" instead of a "s".

Pull request checklist

Please check if your PR fulfills the following:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Tests have been run locally and are passing (shinytest2::test_app())
  • Code is styled according to tidyverse styling (checked locally with styler::style_dir() and lintr::lint_dir())

What is the current behaviour?

See overview.

What is the new behaviour?

All "z" changed to "s".

Anything else

May be others to watch out for.

@JT-39 JT-39 requested a review from ArthurMurrell January 6, 2025 15:45
Copy link
Collaborator

@ArthurMurrell ArthurMurrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked on Tuesday. so just approving now.

@JT-39 JT-39 merged commit 65a14af into main Jan 9, 2025
3 checks passed
@JT-39 JT-39 deleted the remove-zs branch January 9, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants