Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dfeshiny 0.5.3 update #103

Merged
merged 13 commits into from
Jan 2, 2025
Merged

dfeshiny 0.5.3 update #103

merged 13 commits into from
Jan 2, 2025

Conversation

rmbielby
Copy link
Contributor

@rmbielby rmbielby commented Dec 9, 2024

Pull request overview

This updates the template dashboard to use dfeshiny 0.5.3.

Pull request checklist

Please check if your PR fulfills the following:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Tests have been run locally and are passing (shinytest2::test_app())
  • Code is styled according to tidyverse styling (checked locally with styler::style_dir() and lintr::lint_dir())

What is the current behaviour?

What is the new behaviour?

Anything else

Copy link
Contributor

@cjrace cjrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I'd missed this! Couple of quick questions added.

Also, I didn't realise we still had a development branch? Worth deleting after this PR to avoid confusion?

.github/workflows/tidyCode.yaml Outdated Show resolved Hide resolved
renv.lock Outdated Show resolved Hide resolved
@rmbielby rmbielby changed the title dfeshiny 0.5.2 update dfeshiny 0.5.3 update Jan 2, 2025
Copy link
Contributor

@cjrace cjrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing left in from the accessibility panel

ui.R Show resolved Hide resolved
rmbielby and others added 2 commits January 2, 2025 16:17
Co-authored-by: Cam Race <[email protected]>
This reverts commit 32725aa.
@rmbielby
Copy link
Contributor Author

rmbielby commented Jan 2, 2025

One small thing left in from the accessibility panel

I did that and it screwed up the navlist. The additional "Accessibility" isn't from how it's done in the template, it's something I did wrong in dfeshiny function:
https://github.com/dfe-analytical-services/dfeshiny/blob/10839ea6942570856e726072b50c188ef5de684e/R/a11y_panel.R#L110

I've made a PR on dfeshiny to clean it up quickly:

dfe-analytical-services/dfeshiny#83

@rmbielby rmbielby merged commit 61f2769 into main Jan 2, 2025
6 checks passed
@rmbielby rmbielby deleted the development branch January 2, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants