-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dfeshiny 0.5.3 update #103
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I'd missed this! Couple of quick questions added.
Also, I didn't realise we still had a development branch? Worth deleting after this PR to avoid confusion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small thing left in from the accessibility panel
Co-authored-by: Cam Race <[email protected]>
This reverts commit 32725aa.
I did that and it screwed up the navlist. The additional "Accessibility" isn't from how it's done in the template, it's something I did wrong in dfeshiny function: I've made a PR on dfeshiny to clean it up quickly: |
Pull request overview
This updates the template dashboard to use dfeshiny 0.5.3.
Pull request checklist
Please check if your PR fulfills the following:
shinytest2::test_app()
)styler::style_dir()
andlintr::lint_dir()
)What is the current behaviour?
What is the new behaviour?
Anything else