update deployment script to use deployment template defined in dfeshiny #109
+10
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjrace
requested changes
Dec 30, 2024
There was a problem hiding this comment.
This is a really neat solution! I think best to wait until https://github.com/dfe-analytical-services/dfeshiny/pull/74/files is merged in, then finish this PR off. Once it's all in we can then do some testing to make sure it's all working as expected
@rmbielby will definitely be interested in having a look through too when he's back on Thursday
update deployment template to point to main branch of dfeshiny repo
update deploy_parameters template
rmbielby
approved these changes
Jan 20, 2025
cjrace
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
update deploy template to use reusable template defined in dfeshiny R package
...