Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map Example rework #113

Merged
merged 13 commits into from
Jan 15, 2025
Merged

Map Example rework #113

merged 13 commits into from
Jan 15, 2025

Conversation

alex-rogers-hub
Copy link
Contributor

Pull request overview

Rebuilt to replace #110
...

Pull request checklist

Please check if your PR fulfills the following:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Tests have been run locally and are passing (shinytest2::test_app())
  • Code is styled according to tidyverse styling (checked locally with styler::style_dir() and lintr::lint_dir())

What is the current behaviour?

No map
...

What is the new behaviour?

New tab with example leaflet map

...

Anything else

related to issue #82

...

Copy link
Contributor

@rmbielby rmbielby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a few quick comments around the underlying tile choice and the boundary layer/data match-up.

server.R Outdated Show resolved Hide resolved
server.R Show resolved Hide resolved
R/read_data.R Outdated Show resolved Hide resolved
global.R Outdated Show resolved Hide resolved
@alex-rogers-hub alex-rogers-hub merged commit 87be875 into main Jan 15, 2025
5 checks passed
@alex-rogers-hub alex-rogers-hub deleted the map-example-new branch January 15, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants