Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dfeshiny package #66

Merged
merged 11 commits into from
Nov 7, 2023
Merged

Add dfeshiny package #66

merged 11 commits into from
Nov 7, 2023

Conversation

rmbielby
Copy link
Contributor

Pull request overview

The dfeshiny package only has functions to run tidy_code() and support_panel() so far, but I've wired these up to keep momentum. This version of the template allows the user to run the dfeshiny version of tidy code (with the local code having been removed) and renders the support panel using the dfeshiny function.

Aiming to add the updated commit hooks in as well from the KS4 dashboard, which would complement this as that uses tidy_code().

Pull request checklist

Please check if your PR fulfils the following:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Tests have been run locally and are passing (run_tests_locally())
  • Code is styled according to tidyverse styling (checked locally with tidy_code())

@rmbielby rmbielby self-assigned this Oct 27, 2023
.Rprofile Show resolved Hide resolved
.Rprofile Outdated Show resolved Hide resolved
Copy link
Contributor

@cjrace cjrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last small thing before I approve - we seem to get a random line of guidance appear when running the tests?

image

@rmbielby
Copy link
Contributor Author

rmbielby commented Nov 7, 2023

One last small thing before I approve - we seem to get a random line of guidance appear when running the tests?

image

Fixed now

@rmbielby rmbielby merged commit 5f4de28 into main Nov 7, 2023
2 checks passed
@cjrace cjrace deleted the add-dfeshiny branch July 22, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants