Expand acronyms #75
Expand acronyms #75
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -94,7 +94,10 @@ | |||
| source("R/read_data.R") | |||
|
|
|||
| # Read in the data | |||
| dfRevBal <- read_revenue_data() | |||
| dfRevBal <- read_revenue_data() %>% | |||
Check notice
Code scanning / lintr
Variable and function name style should match snake_case or symbols. Note
| @@ -94,7 +94,10 @@ | |||
| source("R/read_data.R") | |||
|
|
|||
| # Read in the data | |||
| dfRevBal <- read_revenue_data() | |||
| dfRevBal <- read_revenue_data() %>% | |||
| mutate(school_phase = case_when(school_phase == "All LA maintained schools" ~ "All local authority maintained schools", | |||
Check notice
Code scanning / lintr
Lines should not be more than 80 characters. This line is 121 characters. Note
| @@ -8,7 +8,7 @@ | |||
| gov_row( | |||
| column( | |||
| 12, | |||
| h1("DfE Analytical Services R-Shiny data dashboard template (h1)"), | |||
| h1("Department for Education (DfE) Analytical Services R-Shiny data dashboard template"), | |||
Check notice
Code scanning / lintr
Lines should not be more than 80 characters. This line is 99 characters. Note
| @@ -103,11 +103,11 @@ | |||
| href = "dfe_shiny_gov_style.css" | |||
| ) | |||
| ), | |||
| shinyGovstyle::cookieBanner("DfE R-Shiny dashboard template"), | |||
| shinyGovstyle::cookieBanner("Department for Education (DfE) R-Shiny dashboard template"), | |||
Check notice
Code scanning / lintr
Lines should not be more than 80 characters. This line is 93 characters. Note
Pull request overview
Expand out acronyms for accessibility (only ones I saw were LA, DfE and EES). Changed DfE in the title of the 'user guide and information' page so that doesn't need replacing elsewhere on the page. Also replaced in the main title and the cookie banner to be safe!
Also remove the heading levels from the actual heading text.
Pull request checklist
Please check if your PR fulfils the following:
run_tests_locally())tidy_code())